Eth registrar #7
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arachnid
requested changes
Oct 4, 2024
|
|
||
| uint256 public immutable MIN_COMMIT_AGE; | ||
| uint256 public immutable MAX_COMMIT_AGE; | ||
| uint256 public constant MIN_REGISTRATION_DURATION = 28 days; |
There was a problem hiding this comment.
Given that we have an owner, maybe we want to make this configurable?
| uint256 public immutable MIN_COMMIT_AGE; | ||
| uint256 public immutable MAX_COMMIT_AGE; | ||
| uint256 public constant MIN_REGISTRATION_DURATION = 28 days; | ||
| mapping(bytes32 => uint256) public commitments; |
There was a problem hiding this comment.
Solidity supports naming mapping keys and values now, which would add clarity here.
Suggested change
| mapping(bytes32 => uint256) public commitments; | |
| mapping(bytes32 hash => uint256 inception) public commitments; |
| uint256 public immutable MAX_COMMIT_AGE; | ||
| uint256 public constant MIN_REGISTRATION_DURATION = 28 days; | ||
| mapping(bytes32 => uint256) public commitments; | ||
| bytes32 public constant ETH_LABELHASH = keccak256(abi.encodePacked("eth")); |
There was a problem hiding this comment.
We can save some bytecode by making this a module level constant (and therefore not a public variable).
| uint256 public constant MIN_REGISTRATION_DURATION = 28 days; | ||
| mapping(bytes32 => uint256) public commitments; | ||
| bytes32 public constant ETH_LABELHASH = keccak256(abi.encodePacked("eth")); | ||
| ETHRegistry public registry; |
|
|
||
| event NameRegistered( | ||
| string label, | ||
| bytes32 labelHash, |
| uint64 expires = currentExpiry + duration; | ||
|
|
||
| // Check if the provided value is sufficient | ||
| IPriceOracle.Price memory price = rentPrice(label, duration); |
There was a problem hiding this comment.
Does this just swallow any extra?
| @@ -0,0 +1,237 @@ | |||
| // import { loadFixture } from '@nomicfoundation/hardhat-toolbox-viem/network-helpers.js' | |||
|
@jefflau do we still need this PR? If not, shall we close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eth registrar on the premise that the commit + registrations happen on L2.
Todo: